Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement float*interval and interval/float #163

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat: Implement float*interval and interval/float #163

merged 2 commits into from
Jul 22, 2024

Conversation

mcheshkov
Copy link
Member

No description provided.

@mcheshkov mcheshkov mentioned this pull request Jul 19, 2024
Merged
4 tasks
srh
srh approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@srh srh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly looked at the arithmetic and how it compares to postgres logic.

@mcheshkov mcheshkov force-pushed the CORE-1034-interval-float-mul branch from 828b9eb to 4f3efdb Compare July 22, 2024 12:53
@mcheshkov mcheshkov merged commit bba28d6 into cubesql-3-04-2022 Jul 22, 2024
23 checks passed
@mcheshkov mcheshkov deleted the CORE-1034-interval-float-mul branch July 22, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srh srh srh approved these changes

@paveltiunov paveltiunov paveltiunov approved these changes

Assignees
No one assigned
Labels
datafusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcheshkov @srh @paveltiunov